From: Michael Lass <bevan@bi-co.net>
Date: Thu, 14 May 2020 18:40:57 +0000 (+0200)
Subject: extensionDownloader: Replace deprecated Soup.SessionAsync
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~684^2^2~390
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=a47e0f9845f936a71c9d466759d4585636e476fd;p=gnome-shell.git

extensionDownloader: Replace deprecated Soup.SessionAsync

Soup.SessionAsync by default sets timeout and idle_timeout to 0. This
causes connections to hang around in state CLOSE_WAIT forever after the
remote host has closed the connection.

To fix this, we could set timeout and idle_timeout manually. However,
Soup.SessionAsync is marked as deprecated anyway and should be replaced
by Soup.Session. Doing so also sets a default timeout of 60 seconds.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2774
---

diff --git a/js/ui/extensionDownloader.js b/js/ui/extensionDownloader.js
index 08ebc2fec..90fc5a616 100644
--- a/js/ui/extensionDownloader.js
+++ b/js/ui/extensionDownloader.js
@@ -238,7 +238,7 @@ class InstallExtensionDialog extends ModalDialog.ModalDialog {
 });
 
 function init() {
-    _httpSession = new Soup.SessionAsync({ ssl_use_system_ca_file: true });
+    _httpSession = new Soup.Session({ ssl_use_system_ca_file: true });
 
     // See: https://bugzilla.gnome.org/show_bug.cgi?id=655189 for context.
     // _httpSession.add_feature(new Soup.ProxyResolverDefault());